Skip to main content
skill CX Codex

combine-code-review — Claude Code skill for Combine reviews

combine-code-review is a Claude Code skill that checks Combine code for subscription, operator, memory, and error-handling issues during Swift code review.

Apache-2.0 123 installs ★ 89 updated 2026-09-15

Install into Claude Code · Skills CLI (Vercel) All methods and platforms ↓
npx skills add existential-birds/beagle --skill combine-code-review -a claude-code
Open on GitHub

What combine-code-review does

The skill reviews Combine chains against a checklist. It checks where AnyCancellable values are kept, whether sink or assign can retain self, whether operators fit the job, and how failures are handled. It also checks scheduling before UI updates and the choice between PassthroughSubject for events and CurrentValueSubject for state.

Reference files cover publishers, operators, memory, and error handling. Before reporting findings, the skill asks the reviewer to establish that the code is in scope, trace subscription lifetimes, and support leak claims with a capture chain. High and critical findings need a file and line reference. When a snippet does not show where a subscription is stored, the skill asks for surrounding code rather than treating it as safe.

What it helps with

  • find discarded or short-lived AnyCancellable values
  • trace strong self captures in sink and assign closures
  • check whether a chain needs switchToLatest instead of flatMap
  • inspect how publisher failures affect the main chain
  • spot UI updates without main-thread scheduling

Example prompts for the agent

  • Review this Combine code for memory leaks and show the capture chains.
  • Inspect this search publisher and decide whether it needs switchToLatest.
  • Check error handling and subscription storage in this file.

How to install combine-code-review

1Skills CLI (Vercel)

npx skills add existential-birds/beagle --skill combine-code-review -a claude-code

2Manually: put the files in place

~/.claude/skills/combine-code-review/SKILL.md

Copy the whole skill folder; for one project use .claude/skills/combine-code-review/

Step by step, with commands for each platform: How to install skills in Claude Code: five ways

Questions about combine-code-review

How do I install combine-code-review in Claude Code?

Run npx skills add existential-birds/beagle --skill combine-code-review -a claude-code. The skill file is at ~/.claude/skills/combine-code-review/SKILL.md.

What does combine-code-review do?

It reviews Combine code for subscription retention, retain cycles, operator choices, and error handling. It also checks scheduling for UI updates.

How does the skill assess a possible retain cycle?

It traces where the cancellable is kept and whether its closure strongly captures self. It labels unconfirmed cases as risks instead of reporting them as confirmed leaks.

Source text

SKILL.md · Apache-2.0
---
name: combine-code-review
description: Reviews Combine framework code for memory leaks, operator misuse, and error handling. Use when reviewing code with import Combine, AnyPublisher, @Published, PassthroughSubject, or CurrentValueSubject.
---

# Combine Code Review

## Quick Reference

| Issue Type | Reference |
|------------|-----------|
| Publishers, Subjects, AnyPublisher | [references/publishers.md](references/publishers.md) |
| map, flatMap, combineLatest, switchToLatest | [references/operators.md](references/operators.md) |
| AnyCancellable, retain cycles, [weak self] | [references/memory.md](references/memory.md) |
| tryMap, catch, replaceError, Never | [references/error-handling.md](references/error-handling.md) |

## Review Checklist

- [ ] All `sink` closures use `[weak self]` when self owns cancellable
- [ ] No `assign(to:on:self)` usage (use `assign(to: &$property)` or sink)
- [ ] All AnyCancellables stored in Set or property (not discarded)
- [ ] Subjects exposed as `AnyPublisher` via `eraseToAnyPublisher()`
- [ ] `flatMap` used correctly (not when `map + switchToLatest` needed)
- [ ] Error handling inside `flatMap` to keep main chain alive
- [ ] `tryMap` followed by `mapError` to restore error types
- [ ] `receive(on: DispatchQueue.main)` before UI updates
- [ ] PassthroughSubject for events, CurrentValueSubject for state
- [ ] Future wrapped in Deferred when used with retry

## When to Load References

- Reviewing Subjects or publisher selection → publishers.md
- Reviewing operator chains or combining publishers → operators.md
- Reviewing subscriptions or memory issues → memory.md
- Reviewing error handling or try* operators → error-handling.md

## Hard gates (before you report findings)

Complete in order. Do not skip ahead while a prior gate is open.

1. **Scope** — **Pass:** You name at least one file or type under review that imports Combine or uses APIs from the Quick Reference (e.g. `AnyPublisher`, `@Published`, `PassthroughSubject`). If none apply, stop with “out of scope.”
2. **Subscription retention** — **Pass:** For each `sink`, `assign`, and `store(in:)` in scope, you state where the `AnyCancellable` is retained (property, `Set`, task lifetime) or mark **ephemeral** with a one-line reason (e.g. synchronous one-shot that cannot outlive caller). If you cannot tell from the snippet, say **unknown** and ask for surrounding storage, do not assume safe.
3. **Retain-cycle claim** — **Pass:** **Confirmed** leak findings state the capture chain (e.g. self → stored cancellable → closure strongly capturing self). Label suspected cases **risk** / **verify**, not confirmed leaks. When arguing safety, cite `[weak self]`, `[unowned self]`, or non-capturing patterns you relied on.
4. **UI / main thread** — **Pass:** For updates to UIKit/SwiftUI from a chain, you either point to `receive(on: DispatchQueue.main)`, `@MainActor`, or equivalent before the UI work, **or** flag missing scheduling with `file:line`.
5. **Severity and checklist** — **Pass:** Every **high** or **critical** item includes `file:line` (or exact pasted lines) and names which **Review Checklist** row it breaks. Lower-severity notes may omit line numbers but must still be reproducible from named files.

## Review Questions

1. Are all subscriptions being retained? (Check for discarded AnyCancellables)
2. Could any sink or assign create a retain cycle with self?
3. Does flatMap need to be switchToLatest for search/autocomplete?
4. What happens when this publisher fails? (Will it kill the main chain?)
5. Are error types preserved or properly mapped after try* operators?

© existential-birds · Apache-2.0 · existential-birds/beagle

Similar skills

All skills for Code review and refactoring →

From the same set68

The whole set →
review-skill-improver review-skill-improver reviews code-review feedback logs, spots recurring rejection patterns, and proposes changes to review skills. Use it after feedback has accumulated and you want to refine review rules. CX Codex +1 125installs elixir-code-review elixir-code-review reviews Elixir files for OTP conventions, security caveats, and idiomatic style across .ex and .exs code. CX Codex +1 124installs app-intents-code-review app-intents-code-review reviews Swift App Intents code for intent structure, shortcuts phrases, entity queries, and iOS deployment quirks. CX Codex +1 124installs review-feedback-schema review-feedback-schema — a skill for recording code review outcomes in CSV and checking the evidence behind each verdict. Use it when review decisions need a history. CX Codex +1 124installs receive-feedback receive-feedback takes review comments from another model, a human or a CI tool and checks each one against the real code before anything is edited. CX Codex +1 123installs reference-docs reference-docs is a Claude Code skill for writing API and symbol reference pages, with parameter tables, return values, errors, and runnable examples. CX Codex +1 121installs widgetkit-code-review widgetkit-code-review is a Claude Code skill that checks WidgetKit widget code against a checklist for timelines, view composition, configurable intents, and memory, before release or after an iOS 17 migration. CX Codex +1 121installs pydantic-ai-model-integration pydantic-ai-model-integration guides LLM provider configuration, fallback model chains, streaming, and token limits in PydanticAI. CX Codex +1 120installs

Project sponsors

Companies that keep this analytics open