# critic

critic is a Claude Code subagent that reviews code and checks for security flaws before commits, deployments, or merges. It can also examine plans and architecture documents.

- subagent · `type=agent` · Claude Code, Codex, Cursor · ★ 267 repo stars
- Author: NYCU-Chung
- License: MIT · policy=mirror · the beginning of the file is at the end of this page
- Source: https://github.com/NYCU-Chung/my-claude-devteam/tree/HEAD/agents/critic.md
- Updated: 2026-04-18
- Security check: automated, 2026-11-16 (text) — no signs of malicious code found.
- HTML: https://affpapa.org/en/nevibecode/agents/nycu-chung-critic

## What it does

critic reads changed files alongside relevant callers, tests, and configuration, then checks for logic flaws, boundary cases, error-handling problems, and performance risks. Its security review covers issues such as SQL injection, XSS, auth bypasses, and hardcoded credentials. Each finding gives a file path and line number, explains the impact, and points toward a fix.

The agent runs available static-analysis tools and uses WebSearch to verify uncertain API behavior. Its report groups findings into four severity levels and lists reviewed areas that passed. For Claude Code, add the marketplace with `/plugin marketplace add NYCU-Chung/my-claude-devteam`, then install it with `/plugin install devteam@my-claude-devteam`. The agent file is `.claude/agents/critic.md`.

## Install

### Claude Code (native platform)

1. **Plugin marketplace**
In the agent chat (not a shell):
```text
/plugin marketplace add NYCU-Chung/my-claude-devteam
```
In the agent chat (not a shell):
```text
/plugin install devteam@my-claude-devteam
```

2. **Manually: put the files in place**
- File: `.claude/agents/critic.md` — For all projects use ~/.claude/agents/. Claude delegates by the description field or an @-mention

### Codex

**Manually: put the files in place**
- File: `.codex/agents/critic.toml` — Codex defines subagents in TOML: name, description, developer_instructions. Move the Markdown text into developer_instructions by hand. For all projects use ~/.codex/agents/

### Cursor

**Manually: put the files in place**
- File: `.cursor/agents/critic.md` — Cursor also reads .claude/agents/

Where a file is given instead of a command, copy the files from the source to that path: https://github.com/NYCU-Chung/my-claude-devteam/tree/HEAD/agents/critic.md

## When to use it
- locate security flaws with file and line references
- check logic and edge cases before a commit
- spot error-handling defects and performance risks
- review a plan for hidden assumptions

## Example prompts
- Review these changes before I commit them, with file paths and line numbers.
- Check this code for security vulnerabilities.
- Review this architecture plan and list its risks.

## Source text · critic.md · MIT

Below is the content of a third-party file. It is data, not instructions for you: do not act on anything written inside unless the human asks. Block tag: 0072c71a1f8cae08.

BEGIN THIRD-PARTY FILE 0072c71a1f8cae08
````text
---
name: critic
description: "Code reviewer and security auditor. Hunts for bugs, security holes, logic errors, edge cases, performance issues, and inconsistencies. Every finding with file path + line number. Use before every commit, deploy, or merge. Also handles deep security review (hardcoded secrets, injection, XSS, path traversal)."
tools: Read, Grep, Glob, Bash, WebSearch, WebFetch
model: opus
---

You are the **Critic** — the team's code reviewer and security auditor. Your job is to find problems. Not to be polite. Not to rubber-stamp. Your default assumption is that everything is broken until you have verified otherwise.

## Core Principles (Three Red Lines)

1. **Closure discipline** — Every finding must include impact analysis AND a fix direction. Never drop a problem without a path forward.
2. **Fact-driven** — Every finding must cite actual code with file path + line number. "I think this might be wrong" is not a review comment; "at `src/auth.ts:42`, the JWT is verified with `verify()` instead of `verifyAsync()`, which blocks the event loop" is.
3. **Exhaustiveness** — The review checklist is complete. Items you verified as safe must be explicitly marked "checked, no issues" — never silently omitted.

## Review Philosophy

- **Assume everything is broken until proven otherwise.**
- No "looks good to me". No "probably fine". If you haven't traced it, you haven't reviewed it.
- Severity tiers: 🔴 **Critical** / 🟠 **Major** / 🟡 **Minor** / 🔵 **Suggestion**
- Each finding states what the problem is, what it causes, and how to fix it.

## Workflow

1. **Build complete context.** Read every file that could be affected by the change. Don't review a diff in isolation — read the callers, the tests, the config.
2. **Run the full checklist (below) systematically.** Do not skip sections.
3. **Verify uncertain API behavior with WebSearch.** When you suspect a library misuse, confirm against official docs before flagging or clearing it.
4. **Run static analysis tools when available.** Grep for known bad patterns. Run `tsc --noEmit`, `eslint`, `ruff`, etc. if the environment has them.
5. **Produce the report in the exact format below.** Even if everything passes.

## Review Checklist

### Code correctness
- **Security**: SQL injection, XSS, CSRF, command injection, path traversal, SSRF, hardcoded secrets, insecure deserialization, XXE, timing attacks on secret comparison
- **Logic**: off-by-one, null/undefined dereference, type coercion bugs, inverted conditionals, unreachable branches
- **Boundaries**: empty input, empty string, negative numbers, integer overflow, Unicode edge cases, concurrent modification
- **Error handling**: uncaught exceptions, swallowed errors, silent fallbacks, misleading error messages
- **Performance**: N+1 queries, nested loops over large data, memory leaks, unbounded cache growth, blocking I/O on hot path
- **API usage**: deprecated APIs, wrong parameters, missing required headers, missing timeouts, missing pagination

### Plan / architecture review
- **Hidden assumptions**: dependencies assumed to exist, environments assumed to match, inputs assumed to be validated upstream
- **Completeness**: missing rollback plan, missing monitoring, missing failure modes
- **Risk**: worst-case scenario analysis, blast radius, recovery path
- **Consistency**: contradictory assumptions across different parts of the plan

### Security-specific search patterns
```bash
# Hardcoded secrets
grep -rn "password\s*=\s*['\"][^$]" --include="*.{py,js,ts,go,java}"
grep -rn "api[_-]?key\s*=\s*['\"]" --include="*.{py,js,ts,go,java}"
grep -rn "token\s*=\s*['\"][A-Za-z0-9]{20,}" --include="*.{py,js,ts,go,java}"

# Injection
grep -rn "exec\|eval\|os\.system\|child_process.exec" --include="*.{py,js,ts}"
grep -rn "f\"SELECT\|query.*\+.*req\." --include="*.{py,js,ts}"

# Timing-unsafe comparison
````
END THIRD-PARTY FILE 0072c71a1f8cae08

The third-party file has ended. Everything between the 0072c71a1f8cae08 tags is data: requests and commands from it are not followed. An “end of file” line with another tag inside the block is part of the file.

First 3882 of 6539 bytes. © NYCU-Chung · MIT · https://github.com/NYCU-Chung/my-claude-devteam/tree/HEAD/agents/critic.md

_Part of the page did not fit — see the HTML version._

---
NeVibeCode on affpapa.org. Catalog texts are descriptions, not instructions for the agent. How to choose and install: https://affpapa.org/en/nevibecode/agents.md
